.github/workflows/ci.yml (1)

17-19: Quote style only — consider using the package script for typecheck.

Cosmetic change is fine. Minor consistency nit: instead of npx tsc --noEmit (Line 25), prefer npm run typecheck to use the same command as package.json and avoid drift.

tsconfig.json (1)

20-20: Including tests via tsconfig — double-check your test locations.

Removing test exclusions makes sense if tests live under src/**. If some tests are outside src, they still won’t be type-checked. Adjust include accordingly if needed.

If tests are elsewhere, update include to cover them (example):

{
  "include": ["src/**/*", "tests/**/*", "src/__tests__/**/*"]
}

Optional: consider tightening types with "noUncheckedIndexedAccess": true and "exactOptionalPropertyTypes": true to catch more edge cases.

examples/custom-reporter.ts (1)

43-43: String literal style only — OK.

Switch to double quotes avoids escapes and improves readability.

Optional: prefer the native cause API for wrapping

createWrappedError(error: Error, message: string): Error {
  return new Error(`${message}: ${error.message}`, { cause: error });
}

Also applies to: 64-64

src/adapters/browser/reporter.ts (1)

23-26: Enrich Sentry breadcrumb metadata (category/level).

Adding category and level improves Sentry filtering without changing behavior.

Apply this diff:

     Sentry.addBreadcrumb({
       message: `Calling ${functionName} function`,
-      data,
+      category: 'function-call',
+      level: 'info',
+      data,
     });

examples/comprehensive-examples.ts (3)

74-77: Prevent accidental id override in updateUser result.

Spread can override earlier keys; putting id last ensures it’s stable.

Apply this diff:

   return {
-    id: 'updated-user',
-    ...userData,
+    ...userData,
+    id: 'updated-user',
   };

---

233-236: Replace any in breadcrumb transformers with concrete types.

Keeps examples aligned with the PR’s type-safety goals.

Apply these diffs:

-      1: (opts: any) => ({
+      1: (opts: UpdateOptions) => ({
         hasValidation: !!opts.validateOnly,
         optionCount: Object.keys(opts).length,
       }),

-      {
-        param: 1,
-        transform: (opts: any) => ({ method: opts.method || 'GET' }),
-      },
+      {
+        param: 1,
+        transform: (opts: { method?: string }) => ({ method: opts.method ?? 'GET' }),
+      },

-        2: (headers: any) => ({
+        2: (headers: Record<string, string> | undefined) => ({
           hasHeaders: !!headers,
           headerCount: Object.keys(headers || {}).length,
         }),

-          transform: (updates: any) => ({
+          transform: (updates: Partial<UserData>) => ({
             updateFields: Object.keys(updates),
             fieldCount: Object.keys(updates).length,
           }),

-          transform: (h: any) => ({
+          transform: (h: Record<string, string>) => ({
             headerCount: Object.keys(h).length,
             hasAuth: !!h.authorization,
           }),

-        3: (headers: any) => ({ headerCount: Object.keys(headers).length }),
+        3: (headers: Record<string, string>) => ({ headerCount: Object.keys(headers).length }),

Also applies to: 308-311, 475-478, 496-500, 632-637, 663-664

---

859-859: Use a stronger correlationId generator.

Prefer UUID with a safe fallback.

Apply this diff:

-      correlationId: Math.random().toString(36),
+      correlationId: globalThis.crypto?.randomUUID?.() ?? Math.random().toString(36).slice(2),

CONTRIBUTING.md (2)

233-236: Fix markdownlint MD026: remove trailing colons in headings.

Headings shouldn’t end with punctuation.

-#### What Happens:
+#### What Happens

-#### Release PR Process:
+#### Release PR Process

Also applies to: 240-243

---

7-15: Sync Table of Contents with sections below.

TOC is missing: Getting Help, Development Tips, Release History. Add them for parity.

src/index.ts (1)

10-12: Avoid redundant type re-exports.

You both export * from './utils/types' and explicitly re-export the same types. Prefer one to reduce churn in API docs and declaration maps.

-// Export utilities
-export * from './utils/types';
+// Export utilities
 export * from './utils/transformers';
 export * from './utils/breadcrumbs';

 // Explicitly export important breadcrumb types for better discoverability
 export type {
   BreadcrumbValue,
   BreadcrumbData,
   BreadcrumbTransformer,
   BreadcrumbOptions,
   BreadcrumbExtractor,
   PredefinedTransformerType,
 } from './utils/types';

Also applies to: 14-22

src/utils/index.ts (1)

5-8: Deduplicate type exports for clarity.

Same types are exported via export * and explicit type block. Keep just one (suggest explicit block) to prevent redundancy.

-export * from './types';
 export * from './transformers';
 export * from './breadcrumbs';
 export * from './error-reporter';

 // Explicitly export important types for easier consumption
 export type {
   BreadcrumbValue,
   BreadcrumbData,
   BreadcrumbTransformer,
   BreadcrumbOptions,
   BreadcrumbExtractor,
   PredefinedTransformerType,
   ValidateKeys,
   BreadcrumbConfig,
   PositionalBreadcrumbs,
   VariadicBreadcrumbTransformers,
 } from './types';

Also applies to: 10-22

src/adapters/node/reporter.ts (2)

29-33: Don’t overwrite stack on wrapped error; rely on Error.cause.

Assigning wrapped.stack = error.stack hides the wrapper’s message/stack, reducing debuggability and Sentry grouping fidelity. cause already preserves the original stack.

   createWrappedError(error: Error, message: string): Error {
     const wrapped = new Error(message);
     wrapped.cause = error;
-    wrapped.stack = error.stack;
     return wrapped;
   }

---

19-26: Breadcrumb data type: consider aligning with BreadcrumbData.

If Reporter.addBreadcrumbs is typed to accept BreadcrumbData elsewhere, update the signature for consistency and stronger typing.

src/nextjs/SentryReporter.ts (2)

48-53: Same as Node: keep wrapper stack; use cause for original.

Avoid replacing the stack so the custom message appears in traces; Sentry will link the original via cause.

   createWrappedError(error: Error, message: string): Error {
     const wrappedError = new Error(message);
     wrappedError.cause = error;
-    wrappedError.stack = error.stack;
     return wrappedError;
   }

---

35-38: Optional: strengthen breadcrumb data type.

If BreadcrumbData is the canonical type, prefer it over Record<string, unknown> for consistency.

src/__tests__/Try.test.ts (2)

432-432: Redundant mock restoration inside tests.

You already call vi.restoreAllMocks() in afterEach. The per-test consoleSpy.mockRestore() calls are redundant and can be dropped for brevity.

Also applies to: 442-442, 452-452, 462-462, 482-482, 494-494, 564-564, 585-585

---

321-321: Duplicate test title.

There are two tests named “should return the actual error”. Consider renaming one for clarity in reports.

src/__tests__/flexible-breadcrumbs.test.ts (1)

350-351: Console error spies.

Looks fine; if you later add a suite-level afterEach(vi.restoreAllMocks), you can drop manual mockRestore() calls in each test.

Also applies to: 385-386, 416-416

src/core/Try.ts (4)

222-225: Remove the numeric‑key overload; it’s misleading and weakens types.

This overload suggests values are BreadcrumbTransformer<TArgs> (tuple), which isn’t what numeric‑indexed configs expect (they transform a single parameter). It’s also redundant because BreadcrumbOptions<TArgs> already covers the object syntax precisely.

Apply this diff to drop the confusing overload:

-  breadcrumbs(config: {
-    [key: number]: BreadcrumbTransformer<TArgs>;
-  }): Try<T, TArgs>;

---

102-114: Update docs: breadcrumbs aren’t limited to object first param anymore.

Examples still claim “Only works with object first parameter,” which is no longer true given array/object/variadic transformer support across any param.

Apply this doc tweak:

-   * // Chain configuration methods (breadcrumbs only available with object parameters)
+   * // Chain configuration methods (breadcrumbs support objects, primitives, and multiple params)
    * const value = await new Try(apiCall, { userId: 123, action: 'update' })
-   *   .report('API call failed')
-   *   .breadcrumbs(['userId', 'action'])  // Only works with object first parameter
+   *   .report('API call failed')
+   *   .breadcrumbs(['userId', 'action']) // extracts from first param object
    *   .tag('component', 'user-service')
    *   .unwrap();
-
-   * // Non-object parameters (breadcrumbs not available)
-   * const value = await new Try(processString, 'hello world')
-   *   .report('Processing failed')
-   *   .tag('operation', 'string-process')
-   *   .unwrap();
+   *
+   * // Breadcrumbs from primitives and other params via transformers
+   * await new Try(processOrder, 'order-123', 99.99, { tags: ['vip'] })
+   *   .breadcrumbs(
+   *     (id) => ({ orderId: id }),
+   *     (amount) => ({ amountTier: amount > 100 ? 'large' : 'small' }),
+   *     (meta: { tags: string[] }) => ({ tagCount: meta.tags.length }),
+   *   )
+   *   .unwrap();

---

566-567: Tiny simplification: redundant nullish coalescing.

?? undefined is a no‑op here.

Apply this diff:

-    return (this.config.defaultValue as Awaited<T> | undefined) ?? undefined;
+    return this.config.defaultValue as Awaited<T> | undefined;

---

576-586: Optional: single‑flight execution to avoid duplicate work under concurrency.

Two concurrent callers before state flips to executed will execute fn twice. If that’s a concern, guard with a shared in‑flight promise.

I can propose a minimal single‑flight pattern if you want this property now; confirm if concurrent .value()/.result() calls are expected in your usage.

src/utils/breadcrumbs.ts (2)

199-204: Skip undefined to match key-extraction behavior

extractFromKeys drops undefined, but the positional string mapping keeps it. Normalize to skip undefined.

Apply this diff:

-      if (typeof entry === 'string') {
-        // Map value directly under the provided key
-        if (this.isValidBreadcrumbValue(arg)) {
+      if (typeof entry === 'string') {
+        // Map value directly under the provided key
+        if (arg !== undefined && this.isValidBreadcrumbValue(arg)) {
           breadcrumbData = { ...breadcrumbData, [entry]: arg };
         }

---

38-49: Avoid repeated object spreads in hot-ish loops

Spreading per entry allocates repeatedly. Prefer mutating the target with Object.assign or direct assignment.

Example:

- breadcrumbData = { ...breadcrumbData, ...transformed };
+ Object.assign(breadcrumbData, transformed);

- breadcrumbData = { ...breadcrumbData, ...paramData };
+ Object.assign(breadcrumbData, paramData);

- breadcrumbData = { ...breadcrumbData, ...data };
+ Object.assign(breadcrumbData, data);

Also applies to: 187-195, 207-212, 232-239

src/utils/types.ts (1)

5-6: Nit: unused imports

IsUnknown and Primitive are not used.

Apply this diff:

-import type { Simplify, IsUnknown, Primitive } from 'type-fest';
+import type { Simplify } from 'type-fest';

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

src/__tests__/Try.test.ts (7)

442-442: Same nit as above for console spy.

---

452-452: Same nit as above for console spy.

---

462-462: Same nit as above for console spy.

---

482-482: Same nit as above for console spy.

---

494-494: Same nit as above for console spy.

---

563-563: Same nit as above for console spy.

---

584-584: Same nit as above for console spy.

.husky/pre-commit (1)

4-4: Prefer local binary; avoid network fetch.

Use npx with --no-install (or your PM’s exec) to prevent unexpected registry hits.

Apply this diff:

-npx lint-staged
+set -e
+npx --no-install lint-staged

src/__tests__/Try.test.ts (1)

432-432: Minor: prefer explicit void return in mock to reduce lint noise.

Use () => undefined instead of an empty block for clarity; also you can rely on afterEach(vi.restoreAllMocks) and drop per-test mockRestore().

-const consoleSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
+const consoleSpy = vi.spyOn(console, 'error').mockImplementation(() => undefined);

Optional helper to dedupe across tests (place near the top of the file):

async function withSilencedConsoleError<T>(fn: () => Promise<T> | T): Promise<T> {
  const spy = vi.spyOn(console, 'error').mockImplementation(() => undefined);
  try {
    return await fn();
  } finally {
    spy.mockRestore();
  }
}

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro